feat: allow to pass promise as response #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime1992
commented
Dec 18, 2023
|
@zakhenry I've made a pre-release to test in my current branch and this works really well. It's letting me delay a request and in the e2e test make sure that a loading page/spinner is displayed and then resolve that promise as soon as the check is done to let the grpc call finish. |
maxime1992
force-pushed
the
feat-allow-to-pass-promise-as-response
branch
from
b13cc47 to
1879753
Compare
zakhenry
reviewed
Dec 21, 2023
| expect(route.request().method(), 'ALL gRPC requests should be a POST request').toBe('POST'); | ||
|
|
||
| const grpcResponse = typeof response === 'function' ? response(readGrpcRequest(route.request())) : response; | ||
| const grpcResponseWrapped = typeof response === 'function' ? response(readGrpcRequest(route.request())) : response; | ||
| const grpcResponse = await Promise.resolve(grpcResponseWrapped); |
There was a problem hiding this comment.
minor possible cleanup
const grpcResponse = await (typeof response === 'function' ? response(readGrpcRequest(route.request())) : response )
but I think they end up functionally equivalent anyway though one less call on the stack
zakhenry
approved these changes
Dec 21, 2023
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.