Cleanup #54
Open
Cleanup #54
+32
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-a-d-nguyen
force-pushed
the
cleanup
branch
from
ba41643 to
ad4d100
Compare
andy-a-d-nguyen
force-pushed
the
cleanup
branch
from
1e2fbe4 to
98992e6
Compare
maxmoehl
requested changes
Nov 29, 2024
There was a problem hiding this comment.
This doesn't compile in its current state, can you please rebase on the current main?
$ go vet ./...
# code.cloudfoundry.org/route-registrar
# [code.cloudfoundry.org/route-registrar]
vet: ./main.go:100:23: cannot use port (variable of type int) as uint16 value in struct literal
# code.cloudfoundry.org/route-registrar/integration
# [code.cloudfoundry.org/route-registrar/integration]
vet: integration/init_test.go:44:13: cannot use test_helpers.NextAvailPort() (value of type uint16) as int value in assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses test fixtures that have been put into one place and converts underscore cased variables to camel cased variables to adhere to Go styling.
Backward Compatibility
Breaking Change? No