Fix acceptance test setup to work on local linux #754
Conversation
Try to read FOCUS variable before you set -u, otherwise it breaks script if params are empty.
When running tests in container, current repository is checked out in /repo folder, which needs adding to safe dirs, as git doesn't like default attributes of mounted folders.
It seems bpm release location has moved. Currently residing in S3 and it gets downloaded as uuid file name. Fix this so that rest of the tests can continue working with same old expected file name.
| git config --global --add safe.directory /repo | ||
| git config --global --add safe.directory /repo/src/ttar |
There was a problem hiding this comment.
It make senses to introduce a variable for the path /repo/src/ttar, since you use it in another scripts in the same folder (ci/scripts)
| git config --global --add safe.directory /repo | ||
| git config --global --add safe.directory /repo/src/ttar |
There was a problem hiding this comment.
It make senses to introduce a variable for the path /repo/src/ttar, since you use it in another scripts in the same folder (ci/scripts)
|
This is more of patching, just to make it work. Scripts run with -e, so any issue in the middle of the execution (which can take say 10 or 15 mins to arrive to that point) means aborting of everything. There also is a lot of duplication (in general) between these two scripts ( We have decided to create improvements/tech debt story to address all of that. This PR remains "light" to get it working for now. |
Few minor fixes to acceptance test scripts and setup so that they can run fine on localhost running linux.