New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nitin to BOSH groups #933

Merged

beyhan merged 4 commits into cloudfoundry:main from xtreme-nitin-ravindran:main

Jul 31, 2024

Member

xtreme-nitin-ravindran commented Jul 25, 2024

Hi there,

I have been a contributor on BOSH (~2015-2016) and stemcell (on-going for compliance).
I am now a part of the BOSH team.

Cheers,
Nitin

rajathagasthya and others added 3 commits

July 2, 2024 17:36


          [#187767351] archive windows-utilities-tests repo

e11bb05

Signed-off-by: Nitin Ravindran <[email protected]>


          Merge remote-tracking branch 'upstream/main'

1f3f131


          make nitin an approver

9c46ccb

Change from reviewer to approver for
- VM deployment lifecycle (BOSH)
- Stemcell Release Engineering (BOSH)

aramprice approved these changes

View reviewed changes

beyhan requested review from jpalermo, rkoster and beyhan

July 26, 2024 06:21

beyhan added the wg label

jpalermo approved these changes

View reviewed changes

Member

jpalermo left a comment

👍

Member

beyhan commented Jul 30, 2024

For reference the contributions of @xtreme-nitin-ravindran:

Foundational Infrastructure: VM deployment lifecycle (BOSH) Contributions

PRs Commented on/Reviewed:

Issues that may be relevant:

2016-08-10T13:22:44Z: fixes formatting using parted on centOS
2016-08-30T16:28:13Z: Update progressbar version from 0.9.2 to 0.21.0
2017-08-23T22:09:39Z: Add basic user-add_windows
2017-09-14T16:13:04Z: Update stemcell version to 3445.7 in bosh-dev.yml
2019-05-03T21:52:05Z: [#165802999] Add missing CIS/STIG audit rules and update auditd.conf
2019-05-30T23:25:52Z: Add CIS and STIG audit rules
2019-09-20T20:29:39Z: STIG: Enable cron logging
2019-09-26T22:54:27Z: CIS: Ensure suspicious packets are logged
2019-09-27T18:53:18Z: STIG: pam related hardening rules
2020-02-28T02:00:47Z: [#168964744] make rsyslog and logrotate configs consistent
2020-02-29T02:40:03Z: [#171553414] add CIS, STIG hardening for ssh
2020-03-11T18:41:38Z: [#171751912] lock password if crypted_password is not set
2023-03-23T20:36:25Z: job to add/update windows registry
2024-04-25T08:16:21Z: Noble pam_lastlog is deprecated its succesor is pam_lastlog2
2024-07-09T21:53:18Z: add missing director roles
2024-07-10T18:34:20Z: comment for extra permissions in integration tests

Code contributions:

2015-09-22T17:52:10Z: Bump bosh-agent
2015-09-22T18:34:17Z: Fix failing test due to mocking file directory creation
2015-10-13T13:56:15Z: [#104119296] Fix unit and integration tests, and make tests compatible with new 1.5 vendoring
2015-10-13T14:39:05Z: [#104119296] bumping go agent repo
2015-10-15T19:56:18Z: [#104125746] Director can be deployed with default gateway settings
2015-10-20T19:07:21Z: bump agent
2015-10-20T19:40:06Z: allow passwordless sudo for users created for bosh-ssh
2015-10-20T19:40:06Z: allow passwordless sudo for users created for bosh-ssh
2015-10-20T19:52:58Z: adding bosh_sudoers group to os image
2015-10-21T13:56:43Z: bump ubuntu and centos OS image
2015-10-21T16:39:47Z: bump agent
2015-10-21T16:41:54Z: allow passwordless sudo for users created for bosh-ssh
2015-10-21T20:03:43Z: bump agent
2015-10-23T18:06:53Z: monit should not start any jobs before pre-start is done
2015-10-23T19:46:15Z: refactor of monit start
2015-10-23T20:36:33Z: remove agent start error logging for old invalid case
2015-10-23T20:39:29Z: bump agent
2015-10-26T20:57:06Z: refactored to avoid using @cloud_plugin_is_provided flag
2015-10-30T15:27:26Z: bosh-init raises an error if compiled release does not match given stemcell os / version
2015-10-30T19:39:26Z: Fix a typo in the stemcell os and version comparison
2015-10-30T19:57:34Z: Add one more test to check for incorrect stemcell os and versions for compiled releases
2015-10-30T20:12:30Z: Make sure that the "extract release" method is called for compiled releases
2015-10-30T20:20:30Z: Fix test that makes sure non-cpi compiled releases are being extracted
2015-11-02T14:57:14Z: bosh-init raises an error if cpi release is compiled
2015-11-03T20:35:50Z: refactor. moved monit status related stuff from start & stop actions to
2015-11-03T22:39:39Z: removed stopped file exist check before it's deletion (in
2015-11-06T15:50:01Z: - changed root device number detection a bit to be more readable
2015-11-06T22:12:11Z: bosh-init can use non-cpi compiled releases
2016-08-10T13:19:25Z: fixes formatting using parted on centOS
2016-08-30T16:24:42Z: Update progressbar version from 0.9.2 to 0.21.0
2017-09-14T16:12:26Z: Update stemcell version to 3445.7 in bosh-dev.yml
2019-05-03T21:32:26Z: [#165802999] add missing audit rules
2019-05-30T23:24:31Z: Add CIS and STIG audit rules
2019-09-13T17:54:36Z: [#168486244] enable cron logging
2019-09-20T20:26:29Z: clean up stig_spec
2019-09-26T22:24:43Z: CIS: Ensure suspicious packets are logged
2019-09-27T18:45:05Z: [#168812689] add pam related hardening rules
2019-09-27T18:45:05Z: [#168812689] add pam related hardening rules
2019-09-27T18:46:26Z: add login.patch
2019-09-27T18:46:26Z: add login.patch
2019-09-27T18:51:00Z: [#168812689] add pam related hardening rules
2019-09-27T18:51:11Z: add login.patch
2019-10-04T17:20:47Z: CIS: sync 50-default.conf and logrotate sttings
2019-10-18T16:18:05Z: Revert "CIS: sync 50-default.conf and logrotate sttings"
2020-02-28T01:57:24Z: [#168964744] make rsyslog and logrotate configs consistent
2020-02-29T02:37:50Z: [#171553414] add CIS, STIG hardening for ssh
2020-03-11T18:22:12Z: [#171751912] lock password if crypted_password is not set
2023-03-23T20:29:34Z: job to add/update windows registry
2024-06-05T22:28:06Z: Handles EFI stemcells in mount-image helper
2024-06-10T21:16:44Z: Manully remove jumpbox/director vars stores
2024-07-09T19:48:23Z: correctly set custom gcp role to be used by int test
2024-07-10T18:30:17Z: comment for extra permissions in integration tests
2024-07-18T18:59:40Z: fixup imports
2024-07-18T19:54:39Z: Make tests more explicit
2024-07-18T19:55:31Z: RemoteManager returns errors when closing created shell

beyhan approved these changes

View reviewed changes

Member

beyhan commented Jul 30, 2024

@xtreme-nitin-ravindran could you please resolve the merge conflict so that we can merge this.


          Merge branch 'main' into main

999b6d3

Member Author

xtreme-nitin-ravindran commented Jul 30, 2024

Member

beyhan commented Jul 31, 2024

IIRC @rkoster is on vacation so I'm merging. Welcome back @xtreme-nitin-ravindran as approver!

beyhan merged commit d72add4 into cloudfoundry:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wg