Add Yusmen Zabanov as a member of the cloudfoundry org #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like contributor names were mostly sorted in lexicographical order (case insensitive) with a few exceptions. This changes fixes the order without changing the list of contributors in any way
beyhan
requested changes
Jul 23, 2024
There was a problem hiding this comment.
I don't find yusmen-zabanov_sap as user and https://github.com/yusmen-zabanov_sap returns 404.
georgethebeatle
force-pushed
the
add_yusmen_zabanov
branch
from
8be7fec to
2563b5c
Compare
georgethebeatle
force-pushed
the
add_yusmen_zabanov
branch
from
2563b5c to
e4252c6
Compare
|
Fair point @beyhan I have provided the proper user now, sorry for the confusion |
|
According to https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-and-revocation
When the above is fulfilled you can merge the pr. |
danail-branekov
approved these changes
Jul 25, 2024
christopherclark
approved these changes
Jul 26, 2024
davewalter
approved these changes
Jul 26, 2024
beyhan
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yusmen is a colleague from SAP who is joining the cf-on-k8s working group