Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARI] Add Michael Chinigo as CLI reviewer #914

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

a-b
Copy link
Member

@a-b a-b commented Jul 2, 2024

@chinigo is a seasoned developer who actively participates in CLI development and maintenance. I endorse him as a CLI reviewer.

Michael is a seasoned developer who actively participates in CLI development and maintenance.
@Gerg Gerg requested review from stephanme and Gerg July 2, 2024 20:02
@Gerg Gerg added the wg label Jul 2, 2024
@Gerg
Copy link
Member

Gerg commented Jul 2, 2024

Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, you need 2 existing CLI approvers to review the application to affirm that Michael meets the criteria for promotion. Once the review is complete, Stephan or I can merge this PR.

@Gerg Gerg changed the title Add Michael Chinigo as CLI reviewer [ARI] Add Michael Chinigo as CLI reviewer Jul 2, 2024
@Gerg
Copy link
Member

Gerg commented Jul 3, 2024

@cloudfoundry/wg-app-runtime-interfaces-cli-approvers for approval

@gururajsh
Copy link
Member

LGTM

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gerg Gerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to ARI!

@Gerg Gerg merged commit 6769e52 into cloudfoundry:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants