Add "Ausaf Ahmed" to Logging and Metrics Reviewers #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
approved these changes
May 9, 2024
beyhan
reviewed
May 10, 2024
Comment on lines
242
to
243
| - name: Ausaf Ahmed | ||
| github: ausafqa |
There was a problem hiding this comment.
When I look for https://github.com/ausafqa I get 404. There is no such user. Is the github user correct?
There was a problem hiding this comment.
I have updated the user handle.
There was a problem hiding this comment.
@beyhan PTAL when you get a chance. Thanks!
beyhan
reviewed
May 21, 2024
There was a problem hiding this comment.
@aqstack could you please add yourself also to the https://github.com/cloudfoundry/community/blob/main/org/contributors.yml. Sorry, I didn't notice this last time. Otherwise all looks fine now.
ameowlia
approved these changes
May 21, 2024
|
#868 - adding aqstack as contributor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to start actively contributing to logging and metrics, and am interested in becoming an approver down the road.