add cnbapplifecycle repo #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyhan
requested review from
a team,
rkoster,
beyhan,
stephanme,
ameowlia and
ChrisMcGowan
and removed request for
a team
stephanme
reviewed
Apr 24, 2024
Co-authored-by: Pavel Busko <[email protected]>
modulo11
force-pushed
the
cnbapplifecycle
branch
from
02d7499 to
efe0dea
Compare
ameowlia
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Hi @modulo11, Thanks for opening this PR.
In order to add a new repo, I think you will also have to open a PR to add it here first. That way the automation will create a blank repo. Then @christopherclark can move it over.(oops this is already done in this PR.)- Are any approvers moving over with this repo? If, so can you add them in the same PR?
- Also, since those approvers probably don't want to maintain other diego components, I think you should create a new area for this.
rkoster
approved these changes
Apr 30, 2024
ChrisMcGowan
approved these changes
Apr 30, 2024
Should we start with the repo just being in the Diego area with no additional approvers. That way we'll have the repo for opening PRs. I guess we'll anyway need to figure out whom to invite for review for some initial work. We can then later figure out how to treat the new lifecycle with regard to approvers. @cloudfoundry/toc WDYT? |
move cnbapplifecycle to its own area in ARP
ameowlia
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @beyhan's comment, we would like to request a cloudfoundry/cnbapplifecycle repository for the lifecycle created within this RFC.
Is that the right spot?
CC @loewenstein @stephanme @ameowlia