Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move benjamintf1 to approver for capi #786

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

@beyhan beyhan added the wg label Mar 4, 2024
@stephanme
Copy link
Contributor

Hi @Benjamintf1,
according to rfc-0008-role-change-process you would need 4 more contributions (PRs, issues and discussions e.g. #capi channel will do as well).
In addition, two existing capi approvers need to give their +1.
Since you are a long term contributor to CF and you have worked in the logging area before, I could imagine to grant you approver rights on a fast-track (i.e. without waiting for 4 additional contributions) if existing capi approvers support this.
Best regards, Stephan

@sethboyles
Copy link
Member

As a CAPI approver, I support fast-tracking @Benjamintf1 as an approver.

@moleske
Copy link
Member

moleske commented Mar 5, 2024

just cause I don't see it here will point out at least one issue Ben has filed against cloud_controller_ng cloudfoundry/cloud_controller_ng#3506 to tack on the list of contributions

giving my approval as well as a CAPI approver

@beyhan beyhan requested a review from stephanme March 5, 2024 08:50
@beyhan
Copy link
Member

beyhan commented Mar 5, 2024

@Benjamintf1 this is still a DRAFT. Is this by intention?

@philippthun
Copy link
Member

+1

@stephanme
Copy link
Contributor

@Benjamintf1: Needed approvals are there now. If you make the PR 'ready for review' (= remove draft), I would merge it.

@Benjamintf1 Benjamintf1 marked this pull request as ready for review March 5, 2024 15:33
Copy link
Contributor

@stephanme stephanme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Benjamintf1, as new approver in the CAPI area.

@stephanme stephanme merged commit 121805a into cloudfoundry:main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants