Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temp team to manage liberty buildpack #779

Closed
wants to merge 1 commit into from
Closed

Add temp team to manage liberty buildpack #779

wants to merge 1 commit into from

Conversation

kevin-ortega
Copy link
Contributor

I am the sole maintainer of the ibm-websphere-liberty-buildpack and I am unable to merge PRs. Looking for a solution to merge a PR.

I am the sole maintainer of the ibm-websphere-liberty-buildpack and I am unable to merge PRs.  Looking for a solution to merge a PR.
@beyhan beyhan requested review from a team, rkoster, beyhan, stephanme, ameowlia and ChrisMcGowan and removed request for a team February 12, 2024 15:11
@beyhan beyhan added the toc label Feb 12, 2024
@ameowlia
Copy link
Member

ameowlia commented Feb 12, 2024

Hi @kevin-ortega, I looked into this a little bit. Here's what I found...

  • You are an approver in the "Buildpacks Java" area of the App Runtime Interfaces area.
  • This gives you the ability to merge approved PRs to the ibm-websphere-liberty-buildpack repo.
  • Currently 1 approval by another working group approver is required per PR for the ibm-websphere-liberty-buildpack repo.
  • There are only 2 other approvers in the "Buildpacks Java" area of the App Runtime Interfaces area.
  • I don't know if those other approvers are active in the ibm-websphere-liberty-buildpack repo, or if they are still active in cf in general.
  • According to this RFC areas with 3 or fewer approvers do not need to require approvals.
  • You can update the settings around approvals by editing this branch protection file.
  • Given that you have <=3 approvers I am surprised that the automation didn't automatically turn off required PR approvals, but I am not the maintainer of the automation.

👉 For now I manually changed the main branch in the ibm-websphere-liberty-buildpack repo such that it doesn't require approvals for PRs. However, the automation will likely change this back within the day.

👉 Instead of giving yourself admin access, you should update the branch protection file to turn off required PR approvals.

@beyhan
Copy link
Member

beyhan commented Feb 13, 2024

There is also a discussion about this in the TOC Slack channel. It turned out that the branch protection is not active for ARI WG and the change done by Amelia should work for now. We also discussed other options that is why this pr is not needed any more. @kevin-ortega please open a new one targeting the discussed options if needed.

@beyhan beyhan closed this Feb 13, 2024
@stephanme
Copy link
Contributor

I put the branch protection topic on the agenda for the next ARI WG meeting (27.2.).

@kevin-ortega kevin-ortega deleted the patch-3 branch February 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants