Archive garden-windows-ci repo #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameowlia
requested review from
a team,
beyhan,
stephanme,
ameowlia and
ChrisMcGowan
and removed request for
a team
ameowlia
approved these changes
Jan 11, 2024
|
This is for my working group and I approve. I can't remember if I need to wait for full TOC approval. |
beyhan
approved these changes
Jan 12, 2024
|
Usually, I take this requests into the TOC meeting but if we get another approval by @rkoster, @stephanme or @ChrisMcGowan we don't need to wait. |
|
You should remove the project from https://github.com/cloudfoundry/community/blob/main/toc/working-groups/app-runtime-platform.md (repositories of area Garden Containers) as well. |
|
@stephanme Done |
ChrisMcGowan
approved these changes
Jan 16, 2024
rkoster
approved these changes
Jan 16, 2024
|
@stephanme thanks for the good catch. The request has been implemented and we have enough approvals I will merge to sped up things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we had some issues with the windows-rootfs pipeline failing because of its references to both garden-windows-ci and the WG CI repo. The conflict arose because we have some opsfiles that have the same name, but different functionality. We were able to fix this by removing the bad opsfile, but it would be better if we had one source of truth for our CI pipelines.
Since
garden-windows-ciis no longer referenced by our pipelines and the relevant files are now in the WG CI repo, we should archivegarden-windows-ci.