Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement inactive user management #713

Merged
merged 15 commits into from
Jan 12, 2024
Merged

Implement inactive user management #713

merged 15 commits into from
Jan 12, 2024

Conversation

beyhan
Copy link
Member

@beyhan beyhan commented Nov 20, 2023

This pr aim is to implement the RFC described in #707

@beyhan beyhan added the toc label Nov 21, 2023
@beyhan beyhan requested review from a team, rkoster, stephanme, ameowlia and ChrisMcGowan and removed request for a team December 5, 2023 14:56
@beyhan beyhan force-pushed the add-inactive-user-removal-automation branch from 94786ab to df76009 Compare December 5, 2023 15:29
@beyhan beyhan force-pushed the add-inactive-user-removal-automation branch from 75d2ec3 to 5dbcc51 Compare December 12, 2023 11:40
@beyhan beyhan requested a review from rkoster December 12, 2023 12:59
stephanme
stephanme requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@stephanme stephanme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are linting and formatting errors reported by: python -m flake8
(see README.md how to run)

What could help to get the action running: a --dry-run flag that just logs what would be done (existing logging might be good enough) and the lets the python script fails so that the PR is not created.

org/org_user_management.py Outdated Show resolved Hide resolved
org/org_user_management.py Outdated Show resolved Hide resolved
org/org_user_management.py Outdated Show resolved Hide resolved
org/org_user_management.py Outdated Show resolved Hide resolved
@beyhan
Copy link
Member Author

beyhan commented Dec 13, 2023

There are linting and formatting errors reported by: python -m flake8 (see README.md how to run)

What could help to get the action running: a --dry-run flag that just logs what would be done (existing logging might be good enough) and the lets the python script fails so that the PR is not created.

Thanks for the feedback! I implemented a --dry-run option in the latest version.

@beyhan beyhan requested a review from stephanme December 13, 2023 15:16
@beyhan beyhan force-pushed the add-inactive-user-removal-automation branch 2 times, most recently from 5e05bcd to 88e4131 Compare December 15, 2023 07:50
@beyhan beyhan requested a review from stephanme December 18, 2023 09:40
stephanme
stephanme reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@stephanme stephanme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there already a dry-run of the new workflow?
Is it really possible to trigger it "as part on a PR", i.e. with modifications in the github action itself?

@beyhan
Copy link
Member Author

beyhan commented Dec 19, 2023

Is there already a dry-run of the new workflow? Is it really possible to trigger it "as part on a PR", i.e. with modifications in the github action itself?

I added now trigger on push to my pr branch and there is run of the job here and the created pr is #736.

@beyhan beyhan force-pushed the add-inactive-user-removal-automation branch from 549f398 to 7fc310e Compare January 12, 2024 08:24
beyhan added 2 commits January 12, 2024 10:02
@beyhan
Activate user tagging in inactive user automation
db6c25e
@beyhan
Compare users case insensitive
dacd3c8 
The users returned by Github and listed in our contributors.yml
are not equal regarding case sensitivity. That is why a case insensitive
comparison is required.
@beyhan
Copy link
Member Author

beyhan commented Jan 12, 2024

The latest run is available in #736. I had to fix two small things but nothing changed in the behaviour and the run looks good. I'm going to merge this.

@beyhan beyhan merged commit 24d074f into main Jan 12, 2024
3 checks passed
@beyhan beyhan deleted the add-inactive-user-removal-automation branch January 12, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMcGowan ChrisMcGowan ChrisMcGowan approved these changes

@stephanme stephanme stephanme approved these changes

@rkoster rkoster rkoster approved these changes

@ameowlia ameowlia Awaiting requested review from ameowlia ameowlia was automatically assigned from cloudfoundry/toc

Assignees
No one assigned
Labels
toc
Projects
CF Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beyhan @rkoster @stephanme @ChrisMcGowan