Unrevert add parity with wrangler action #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 10d5b9c.
Maximo-Guk
changed the title
Maximo-Guk
commented
Oct 31, 2024
Maximo-Guk
commented
Oct 31, 2024
| @@ -33,6 +36,7 @@ const config = { | |||
| COMMANDS: getMultilineInput("command"), | |||
| QUIET_MODE: getBooleanInput("quiet"), | |||
| PACKAGE_MANAGER: getInput("packageManager"), | |||
| WRANGLER_OUTPUT_DIR: `${join(tmpdir(), "wranglerArtifacts")}`, | |||
There was a problem hiding this comment.
Use tmpdir for wranglerArtifacts
Maximo-Guk
force-pushed
the
maximo/unrevert-add-parity-with-wrangler-action
branch
8 times, most recently
from
4b57c63 to
dfe59a0
Compare
jrf0110
reviewed
Nov 1, 2024
Maximo-Guk
force-pushed
the
maximo/unrevert-add-parity-with-wrangler-action
branch
3 times, most recently
from
7f2d331 to
29516d3
Compare
jrf0110
approved these changes
Nov 1, 2024
…d by root. - Github self hosted runners may not have permissions to write to /opt/ - Also fallsback to trying to extract the deployment-url and deployment-alias-url from stdout when WRANGLER_OUTPUT_DIR is not specified
Maximo-Guk
force-pushed
the
maximo/unrevert-add-parity-with-wrangler-action
branch
from
29516d3 to
122ee5c
Compare
Maximo-Guk
deleted the
maximo/unrevert-add-parity-with-wrangler-action
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreverts #303
Tested pipelines here:
deployment-urlanddeployment-alias-urlif wrangler version doesn't output metadata fileMoves wrangler output to tmpdir rather than /opt/ since /opt/ is owned by root.
Github self hosted runners may not have permissions to write to /opt/ Release 3.10.0 fails depending on the file system permissions #306
Also fallsback to trying to extract the deployment-url and deployment-alias-url from stdout when WRANGLER_OUTPUT_DIR is not specified