Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to remove deprecation warnings #236

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update README.md to remove deprecation warnings #236

merged 1 commit into from
Feb 16, 2024

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented Feb 10, 2024

actions/checkout@v3 runs on node16 which is sunset by GitHub Action runners.

resolves #232

`actions/checkout@v3` runs on node16 which is sunset by GitHub Action runners.
@boidolr boidolr requested a review from a team as a code owner February 10, 2024 15:52
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the CI tests to fail. We'll need these to pass before we can land this.

@boidolr
Copy link
Contributor Author

boidolr commented Feb 16, 2024

This causes the CI tests to fail. We'll need these to pass before we can land this.

I am not clear on what to change here. The README.md changed, and now a build complains about CLOUDFLARE_API_TOKEN not being set when building. Any guidance on what exactly needs to change?

@petebacondarwin
Copy link
Contributor

Doh! Sorry. My mistake. Since the PR is coming from your fork, you don't have access to the secrets in Github for the action to run successfully.

@petebacondarwin petebacondarwin merged commit 78c994f into cloudflare:main Feb 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to avoid Node16 deprecation warning
2 participants