WC-2695 Add better visibility for router-worker #6941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d5d8fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GregBrimble
reviewed
Oct 10, 2024
GregBrimble
reviewed
Oct 10, 2024
GregBrimble
reviewed
Oct 10, 2024
WillTaylorDev
force-pushed
the
willtaylor/wc-2695-add-worker-visibility
branch
from
93a0135 to
3f6da9d
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-wrangler-6941You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6941/npm-package-wrangler-6941Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-wrangler-6941 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-create-cloudflare-6941 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-kv-asset-handler-6941npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-miniflare-6941npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-pages-shared-6941npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-vitest-pool-workers-6941npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-workers-editor-shared-6941npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-workers-shared-6941Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
This commit instruments the router worker with analytics such as request time, colo metadata, error, etc, in order for us to have better visibility into the router worker. These changes were tested using gradual rollouts with a 0% version and a Cloudflare-Workers-Version-Overrides header.
WillTaylorDev
force-pushed
the
willtaylor/wc-2695-add-worker-visibility
branch
from
3f6da9d to
3d5d8fa
Compare
GregBrimble
approved these changes
Oct 10, 2024
WalshyDev
approved these changes
Oct 10, 2024
petebacondarwin
approved these changes
Oct 11, 2024
| @@ -16,7 +29,9 @@ interface Env { | |||
| export default { | |||
| async fetch(request: Request, env: Env, ctx: ExecutionContext) { | |||
| let sentry: ReturnType<typeof setupSentry> | undefined; | |||
| const maybeSecondRequest = request.clone(); | |||
| const analytics = new Analytics(); | |||
There was a problem hiding this comment.
NIT: similar to the PerformanceTimer, why not pass in the env.ANALYTICS and env.ENVIRONMENT here in the constructor, rather than in the write method?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes #WC-2695
This commit instruments the router worker with analytics such as request time, colo metadata, error, etc, in order for us to have better visibility into the router worker.
These changes were tested using gradual rollouts with a 0% version and a Cloudflare-Workers-Version-Overrides header.
Author has addressed the following