Fix blob upload verify hash bypass #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dramelac
changed the title
east4ming
pushed a commit
to east4ming/serverless-registry
that referenced
this pull request
Jan 11, 2025
* Fix empty string detection + undefined bypass * Delete upload file from R2 after cancel
east4ming
pushed a commit
to east4ming/serverless-registry
that referenced
this pull request
Jan 11, 2025
* Fix empty string detection + undefined bypass * Delete upload file from R2 after cancel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
verifyHashis checked if the string is not empty but in some cases,undefinedis supplied to the function to bypass the hash verification but!undefined === trueso an error is raise.This PR change the check to explicitly detect the undefined value and continue the execution.
This change fix the issue #86:
This PR also remove the temporary upload file from the R2 bucket after the upload abort.