WIP: qlog: move sent_at_time to extension field #1737
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we added our own `send_at_time` field to packet_sent events, in order to help analysis of pacing related code. Recently, the qlog specs have been changed to allow for better extensibility of individual events. Rather than have each extension field defined at the same level as the base fields in specs, they are instead put in an extension type that serialized as an "anonymous" field. In this change, we move `send_at_time` to a new extension type and use serde flatten to place them at the same level as base events in serialized logs.
LPardue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we added our own
send_at_timefield to packet_sentevents, in order to help analysis of pacing related code.
Recently, the qlog specs have been changed to allow for better
extensibility of individual events. Rather than have each extension field
defined at the same level as the base fields in specs, they are instead
put in an extension type that serialized as an "anonymous" field.
In this change, we move
send_at_timeto a new extension type anduse serde flatten to place them at the same level as base events in
serialized logs.