Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blindrsa: add support for all variants of RFC9474 #479

Merged
merged 2 commits into from
Feb 17, 2024
Merged

blindrsa: add support for all variants of RFC9474 #479

merged 2 commits into from
Feb 17, 2024

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 14, 2024 •
edited
Loading

This package is now fully compliant with the RFC-9474 document, and supports all the variants.

API changes: see func Example_blindrsa() for the new API.

Closes #460

@armfazh armfazh added enhancement Improvement over something already in the project changesAPI PR changes the API of a package labels Feb 14, 2024
@armfazh armfazh self-assigned this Feb 14, 2024
thibmeu
thibmeu reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks ok.
the change from Verifier to Client also reflects the spec better.

blindsign/blindrsa/brsa_test.go Show resolved Hide resolved
blindsign/blindrsa/brsa_test.go Outdated Show resolved Hide resolved
blindsign/blindrsa/brsa.go Outdated Show resolved Hide resolved
@armfazh armfazh requested a review from thibmeu February 15, 2024 22:29
thibmeu
thibmeu approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor modification on file name.

the pr looks good otherwise. it's great to see the transition to rfc 9474

blindsign/blindrsa/testdata/test_rsa2048_rfc9500.json Outdated Show resolved Hide resolved
@armfazh armfazh merged commit fd7a97f into cloudflare:main Feb 17, 2024
10 checks passed
@armfazh armfazh deleted the rfc9474_addVariants branch February 17, 2024 01:30
@armfazh armfazh mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibmeu thibmeu thibmeu approved these changes

@bwesterb bwesterb Awaiting requested review from bwesterb

Assignees

@armfazh armfazh

Labels
changesAPI PR changes the API of a package enhancement Improvement over something already in the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blindrsa: update test vectors to match RFC9474
2 participants
@armfazh @thibmeu