-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-Wing PQ/T hybrid #471
Open
bwesterb
wants to merge
6
commits into
main
Choose a base branch
from
bas/xwing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
X-Wing PQ/T hybrid #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
force-pushed
the
bas/ml-kem
branch
4 times, most recently
from
August 13, 2024 11:27
6d7c6f4
to
9095c87
Compare
bwesterb
force-pushed
the
bas/ml-kem
branch
2 times, most recently
from
August 15, 2024 18:54
7fe1dfc
to
e85bad2
Compare
bwesterb
force-pushed
the
bas/xwing
branch
2 times, most recently
from
August 16, 2024 13:35
cd46a06
to
296b103
Compare
Aligns with what will likely be -01
armfazh
reviewed
Oct 22, 2024
@@ -0,0 +1,299 @@ | |||
// xwing implements the X-Wing PQ/T hybrid KEM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// xwing implements the X-Wing PQ/T hybrid KEM | |
// Package xwing implements the X-Wing PQ/T hybrid KEM |
"github.com/cloudflare/circl/kem" | ||
) | ||
|
||
type otherKEM struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
type otherKEM struct { | |
// genericNoAuthKEM wraps a generic KEM (kem.Scheme) to be used as a HPKE KEM. | |
type genericNoAuthKEM struct { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of X-Wing PQ/T hybrid.