Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage WAF dashboards with Terraform instead of the console #1578

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

jameshochadel
Copy link
Contributor

@jameshochadel jameshochadel commented Nov 2, 2023

Changes proposed in this pull request:

security considerations

No sensitive information included.

@jameshochadel jameshochadel requested a review from a team November 2, 2023 14:46
@jameshochadel jameshochadel marked this pull request as draft November 2, 2023 15:00
The name is failing validation due to the space. Spaces are legal in dashboard names, but this is the path of least resistance.
@jameshochadel jameshochadel marked this pull request as ready for review November 2, 2023 15:58
@jameshochadel jameshochadel changed the title Manage Production WAF dashboard with Terraform instead of the console Manage WAF dashboards with Terraform instead of the console Nov 2, 2023
@jameshochadel jameshochadel merged commit 9290694 into main Nov 2, 2023
3 checks passed
@jameshochadel jameshochadel deleted the cloudwatch-dashboard-waf branch November 2, 2023 17:08
@jameshochadel
Copy link
Contributor Author

Too late to update the commit messages, but I was wrong about having spaces in dashboard names, and Terraform was right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants