Merge pull request #50 from climatepolicyradar/feature/pdct-1245-copy…

…-document-role-into-family-doc-metadata-column-object Feature/pdct 1245 make family document metadata column not nullable
climatepolicyradar · Jul 9, 2024 · b71088e · b71088e
2 parents 80d83d7 + 21b7b12
commit b71088e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/db_client/alembic/versions/0045_copy_document_role_into_metadata.py b/db_client/alembic/versions/0045_copy_document_role_into_metadata.py
@@ -6,7 +6,9 @@
 
 """
 
+import sqlalchemy as sa
 from alembic import op
+from sqlalchemy.dialects import postgresql
 
 revision = "0045"
 down_revision = "0044"
@@ -27,6 +29,12 @@ def upgrade():
 WHERE family_document.import_id = subquery.import_id
 AND family_document.valid_metadata IS NULL"""
     )
+    op.alter_column(
+        "family_document",
+        "valid_metadata",
+        existing_type=postgresql.JSONB(astext_type=sa.Text()),
+        nullable=False,
+    )
 
 
 def downgrade():

diff --git a/db_client/models/dfce/family.py b/db_client/models/dfce/family.py
@@ -230,7 +230,7 @@ class FamilyDocument(Base):
         lazy="joined",
     )
 
-    valid_metadata = sa.Column(postgresql.JSONB)
+    valid_metadata = sa.Column(postgresql.JSONB, nullable=False)
 
 
 class Slug(Base):