-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to run trunk & check for FIXMEs on PR #96
Merged
katybaulch
merged 61 commits into
main
from
PDCT-916/add-precommit-hooks-to-db-client-to-bring-in-line-with-other-repos
Mar 13, 2024
Merged
Attempt to run trunk & check for FIXMEs on PR #96
katybaulch
merged 61 commits into
main
from
PDCT-916/add-precommit-hooks-to-db-client-to-bring-in-line-with-other-repos
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5e68d1f.
…-bring-in-line-with-other-repos
This reverts commit 7b7d08f.
asacristani
approved these changes
Mar 13, 2024
katybaulch
deleted the
PDCT-916/add-precommit-hooks-to-db-client-to-bring-in-line-with-other-repos
branch
March 13, 2024 10:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable trunk check for admin backend repo. More info on trunk check here.
detect-aws-credentials
,check_json
andend-of-file-fixer
. A more exhaustive list can be found here, but they need to be manually enabled in the trunk.yaml fileProposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist