Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/pdct 670 blanking language causes problems #57

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Bugfix/pdct 670 blanking language causes problems #57

merged 4 commits into from
Dec 7, 2023

Conversation

katybaulch
Copy link
Contributor

@katybaulch katybaulch commented Dec 7, 2023 •
edited
Loading

Description

  • Remove entry from language table if user language in doc update is None.
  • Only add language link on document create if language is not null.
  • Added integration tests for these.

Linear ticket PDCT-670

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

New integration tests added.

Reviewer Checklist

  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from diversemix December 7, 2023 15:48
@linear Linear
Copy link

linear bot commented Dec 7, 2023

PDCT-670 Blanking language causes problems

diversemix
diversemix approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gold 🥇

@katybaulch katybaulch merged commit 15c7ec7 into main Dec 7, 2023
2 checks passed
@katybaulch katybaulch deleted the bugfix/PDCT-670-blanking-language-causes-problems branch December 7, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diversemix diversemix diversemix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katybaulch @diversemix