Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pdct 654 return empty 200 on all search entities when no results foun #54

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Feature/pdct 654 return empty 200 on all search entities when no results foun #54

merged 13 commits into from
Dec 6, 2023

Conversation

katybaulch
Copy link
Contributor

@katybaulch katybaulch commented Dec 6, 2023 •
edited
Loading

Description

Please include:

  • Extended search for collection, event, and document entities.
  • Returned 200 instead of 404 when no matching entries found in DB.
  • Added tests for all of this.
  • Linear ticket PDCT-654

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Added unit and integration tests.

Reviewer Checklist

  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from diversemix December 6, 2023 11:53
@linear Linear
Copy link

linear bot commented Dec 6, 2023

PDCT-654 Return empty 200 on all search entities when no results found

diversemix
diversemix approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katybaulch katybaulch merged commit 30bf41e into main Dec 6, 2023
2 checks passed
@katybaulch katybaulch deleted the feature/pdct-654-return-empty-200-on-all-search-entities-when-no-results-foun branch December 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diversemix diversemix diversemix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katybaulch @diversemix