Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audit logging to CloudWatch #43

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Add Audit logging to CloudWatch #43

merged 2 commits into from
Nov 1, 2023

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented Nov 1, 2023 •
edited
Loading

Description

Adds simple audit logging - no tests

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@linear Linear
Copy link

linear bot commented Nov 1, 2023

PDCT-523 Review logging - check there's enough for auditing

@diversemix diversemix requested a review from katybaulch November 1, 2023 15:05
katybaulch
katybaulch approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!! 🧙‍♀️

katybaulch
katybaulch approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@diversemix diversemix merged commit c2ad271 into main Nov 1, 2023
2 checks passed
@diversemix diversemix deleted the PDCT-523/add-auditing-logging branch November 1, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katybaulch katybaulch katybaulch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diversemix @katybaulch