New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDCT 520/review FIXME TODOs #35

Merged

katybaulch merged 2 commits into main from PDCT-520/review-FIXME-TODOs

Oct 25, 2023

Contributor

diversemix commented Oct 24, 2023 •

edited

Loading

Description

Review TODOs, removing where deemed not needed.
Fix FIXME and code! Please check this as this necessitated a code change too

Type of change

Please select the option(s) below that are most relevant:

Bug fix
New feature
Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

The PR represents a single feature (small driveby fixes are also ok)
The PR includes tests that are sufficient for the level of risk
The code is sufficiently commented, particularly in hard-to-understand areas
Any required documentation updates have been made
Any TODOs added are captured in future tickets
No FIXMEs remain

diversemix added 2 commits

October 24, 2023 16:21


          Review TODOs

04193cb


          Fix FIXME and code!

ae93567

linear bot commented Oct 24, 2023

PDCT-520 Go through and audit all FIXME and TODO comments

diversemix requested review from katybaulch and alaniswright

October 24, 2023 15:27

katybaulch approved these changes

View reviewed changes

Contributor

katybaulch left a comment

LGTM 👍

katybaulch merged commit 9055a34 into main

2 checks passed

katybaulch deleted the PDCT-520/review-FIXME-TODOs branch

October 25, 2023 09:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet