Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdct 313 Implement DB delete for family events. #30

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Pdct 313 Implement DB delete for family events. #30

merged 14 commits into from
Oct 23, 2023

Conversation

katybaulch
Copy link
Contributor

No description provided.

@katybaulch katybaulch requested a review from diversemix October 23, 2023 09:55
@linear
Copy link

linear bot commented Oct 23, 2023

PDCT-313 Endpoint for deleting events

@katybaulch katybaulch closed this Oct 23, 2023
@katybaulch katybaulch reopened this Oct 23, 2023
@katybaulch katybaulch changed the title Pdct 313 Added deleted to event status enum for testing. Pdct 313 Implement DB delete. Oct 23, 2023
@katybaulch katybaulch changed the title Pdct 313 Implement DB delete. Pdct 313 Implement DB delete for family events. Oct 23, 2023
@katybaulch katybaulch requested a review from diversemix October 23, 2023 11:10
diversemix
diversemix approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - the duplicated assertion isn't a show stopper 👍

@katybaulch katybaulch merged commit e0ab24c into main Oct 23, 2023
2 checks passed
@katybaulch katybaulch deleted the PDCT-313-endpoint-for-deleting-events branch October 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diversemix diversemix diversemix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katybaulch @diversemix