Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDCT-420 Implement reading the user and model defined language for a document #29

Merged
merged 8 commits into from
Oct 23, 2023
Merged

PDCT-420 Implement reading the user and model defined language for a document #29

merged 8 commits into from
Oct 23, 2023

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented Oct 23, 2023 •
edited
Loading

Description

  • update db schema
  • Implement reading the user and model defined language for a document
  • Implement and test updating the user language

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@linear
Copy link

linear bot commented Oct 23, 2023

PDCT-420 Add language to the document endpoints

@diversemix diversemix marked this pull request as draft October 23, 2023 09:34
diversemix
diversemix commented Oct 23, 2023
View reviewed changes
app/repository/document.py Outdated Show resolved Hide resolved
integration_tests/setup_db.py Outdated Show resolved Hide resolved
@diversemix diversemix marked this pull request as ready for review October 23, 2023 11:33
@diversemix diversemix requested a review from katybaulch October 23, 2023 11:33
katybaulch
katybaulch approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - building that query must have been fun 😉

@diversemix diversemix merged commit 70867e6 into main Oct 23, 2023
2 checks passed
@diversemix diversemix deleted the PDCT-420/user-language branch October 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katybaulch katybaulch katybaulch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diversemix @katybaulch