feature/pdct-1777-support-multiple-geos-in-get #268

odrakes-cpr · 2024-12-19T13:57:09Z

Description

Support multiple geographies in the get request.

Create a subquery that aggregates all the family geographies into a list, insert this subquery into the main query.
Update the family_dto function to extract those values
To ensure backwards compatibility with the front-end add new property key with geographies, and for the current geography property select the first element of the list.
Update tests accordingly
Duplicated the query for the search endpoint, whilst we work on the get endpoint - this should enable backwards compatibility

Please include:

a summary of the changes
links to any related issue/ticket
any additional relevant motivation and context
details of any dependency updates that are required for this change

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

[] Skip auto-tagging
Patch
Minor version
Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

If none of these options are selected, auto-tagging will fail
Where multiple options are selected, the most senior option ticked will be
used -- e.g. Major > Minor > Patch
If you are selecting the version in the list above using the textbox, make
sure your selected option is marked [x] with no spaces in between the
brackets and the x

Type of change

Please select the option(s) below that are most relevant:

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
The PR represents a single feature (small drive-by fixes are also ok)
The PR includes tests that are sufficient for the level of risk
The code is sufficiently commented, particularly in hard-to-understand areas
Any required documentation updates have been made
Any TODOs added are captured in future tickets
No FIXMEs remain

…mily

linear · 2024-12-19T13:57:12Z

PDCT-1777 Support multiple geos in /get

- remove commented out code

odrakes-cpr · 2024-12-23T13:53:21Z

get request

- Have had to rework this one slightly because the get_query function for families has been updated for multi geos, the query no longer returns a row with the geography table and family geo table joined. As a query for a family will return multiple rows if there are more than one geography associated - these are now aggregated into a list of geographies. Therefore the filtering would no longer work, i have flipped the script and included a subquery that retrieves families import ids associated with the geographies and then filters the query based on those.

odrakes-cpr · 2025-01-06T10:53:06Z

Refactored family/search/query params function

app/model/family.py

app/repository/family.py

tests/helpers/family.py

tests/integration_tests/setup_db.py

…t does this is so we can progressively make the change and not risk breaking search

app/repository/family.py

…ub.com:climatepolicyradar/navigator-admin-backend into feature/pdct-1777-support-multiple-geos-in-get

katybaulch

lgtm, nice work!!

…ub.com:climatepolicyradar/navigator-admin-backend into feature/pdct-1777-support-multiple-geos-in-get

feat: WIP - update query to accomodate for multi geos related to a fa…

1b866a7

…mily

odrakes-cpr requested a review from a team as a code owner December 19, 2024 13:57

odrakes-cpr marked this pull request as draft December 19, 2024 13:57

katybaulch and others added 3 commits December 19, 2024 14:52

Added lazy load to prevent multiplicity

edc17a7

refactor: update subquery to aggregate geography values

09090b4

- remove commented out code

Merge branch 'main' into feature/pdct-1777-support-multiple-geos-in-get

c62a0cf

odrakes-cpr marked this pull request as ready for review December 23, 2024 13:49

odrakes-cpr marked this pull request as draft December 23, 2024 13:55

Osneil Drakes and others added 8 commits December 23, 2024 14:05

feat: update package in pyproject

7984c15

merge main fixes

972a0a4

fix: add back in default logging which was commented out in debugging

f94e447

test: update unit tests for new geos field

8fa05c0

chore: make the test errors verbose when running pytest

a55f579

Merge branch 'main' into feature/pdct-1777-support-multiple-geos-in-get

5b560e5

tests: update integration tests with new geo property on families model

ed496c2