-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local development via Docker #261
Conversation
169ab04
to
b73d15f
Compare
b73d15f
to
1cc1e0d
Compare
@@ -69,7 +69,7 @@ lint: | |||
- [email protected] | |||
- [email protected] | |||
- [email protected] | |||
- [email protected].1 | |||
- [email protected].9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needed updating to be able to parse Dockerfiles with HEREDOC
…r-admin-backend into docker-orchestration
17cf05b
to
1227be3
Compare
30db281
to
5333359
Compare
unit_test: build | ||
docker compose run --rm navigator-admin-backend pytest -vvv tests/unit_tests | ||
dev_rds_dump: | ||
[ ! -f ./dumps/navigator.sql ] && aws --profile staging s3 cp s3://cpr-staging-rds/dumps/navigator.sql ./dumps/ || echo 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently a file auto generated every day manually. We will try to make this more automated in future.
0555c16
to
5f0a815
Compare
All looks good so far, I will say when running locally - I am getting an error I believe due to the
|
Ah, interesting - I wonder if this is because we've tended not to run the whole suit as a whole, did you get this from running |
yes, it was from make test |
@odrakes-cpr - I've added some |
…cyradar/navigator-admin-backend into docker-orchestration
This reverts commit 7f8e5b0.
@odrakes-cpr - this seems to fix the env variables problem we were having. I'm not a huge fan of the solution, and would like to dig into a better one, but I think it's a solution for now to help us get this in. |
Description
Creating local, Docker based development workflows for:
This doesn't optimise
Dockerfile
anddocker-compose
files to avoid breaking things already used in prod. This is already a large PR and I want to focus on the dev workflow.The README should describe the workflow
https://github.com/climatepolicyradar/navigator-admin-backend/pull/261/files?plain=1#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R25-R50
I've found this PR easier to review in split mode https://github.com/climatepolicyradar/navigator-admin-backend/pull/261/files?diff=split&w=0
Main features that these workflows support
.env
dependant on context, but rather set them on the context of where they are neededThings this could do, but feels out of scope or optimisations for later
Proposed version
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Part of https://linear.app/climate-policy-radar/issue/PDCT-1719/discuss-integration-tests-destroying-local-db-in-admin-service-backend
Fixes https://linear.app/climate-policy-radar/issue/PDCT-1719/discuss-integration-tests-destroying-local-db-in-admin-service-backend