Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdct 312 Added endpoint for creating events #24

Merged
merged 17 commits into from
Oct 18, 2023
Merged

Pdct 312 Added endpoint for creating events #24

merged 17 commits into from
Oct 18, 2023

Conversation

katybaulch
Copy link
Contributor

Description

Please include:

  • Added endpoint for creating events.
  • Added service and repo functionality for creating tests.
  • Added tests for create endpoint.

Link to Linear ticket

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Unit and integration tests have been added.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from diversemix October 18, 2023 15:46
@linear
Copy link

linear bot commented Oct 18, 2023

PDCT-312 Endpoint for creating events

diversemix
diversemix reviewed Oct 18, 2023
View reviewed changes
app/service/event.py Outdated Show resolved Hide resolved
diversemix
diversemix approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptive approve when comment is back 💯 great stuff

@katybaulch katybaulch merged commit 740548d into main Oct 18, 2023
@katybaulch katybaulch deleted the PDCT-312-endpoint-for-creating-events branch October 18, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diversemix diversemix diversemix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katybaulch @diversemix