Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDCT 419 Fully implement Document writes #14

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented Sep 27, 2023

Description

  • Create DocumentWriteDTO to be used for update
  • Fully implement document updates

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@linear
Copy link

linear bot commented Sep 27, 2023

PDCT-419 Make a DocumentWriteDTO and decide what can be changed

… current implementation is just changing the document title. So best guess is:

class DocumentWriteDTO(BaseModel):
    """Representation of a Document."""
    variant_name: str
    role: str
    type: str
    title: str

@diversemix diversemix changed the title PDCT 419/doc write dto PDCT 419 Fully implement Document writes Sep 27, 2023
@diversemix diversemix merged commit 1650d28 into main Sep 27, 2023
@diversemix diversemix deleted the PDCT-419/doc-write-dto branch September 27, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant