Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use new taxonomy schema #109

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented Mar 27, 2024

Description

Changes the function get_schema_for_org to use the new schema

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

Copy link

linear bot commented Mar 27, 2024

@diversemix diversemix marked this pull request as ready for review March 27, 2024 11:26
@diversemix diversemix requested a review from a team as a code owner March 27, 2024 11:26
@diversemix diversemix changed the base branch from main to PDCT-889/corpus-milestone-3 March 27, 2024 11:30
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 🦖

@diversemix diversemix merged commit d4be670 into PDCT-889/corpus-milestone-3 Mar 27, 2024
9 checks passed
@diversemix diversemix deleted the PDCT-944/update-metadata branch March 27, 2024 12:30
diversemix added a commit that referenced this pull request Apr 2, 2024
* Update to use new taxonomy schema (#109)

* fix db-client and upgrade

* make changes to code and tests

* update config to use new schema (#111)

* PDCT-945 update family functions to remove use of FamilyOrganisation (#112)

* fix db-client and upgrade

* make changes to code and tests

* Remove use of FamilyOrganisation

* update test setup to only setup new schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants