Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDCT 998/ensure new documents have relationships in old and new schema #107

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented Mar 26, 2024

Description

  • Upgrade dbclient to v3.2.1 & remove ruff config
  • Configure pyright to work with pyenv in makefile
  • Add pyrightconfig to gitignore & add trunk ignores
  • Add ruff config for trunk
  • Populate old and new schema for new families.
  • Don't add corpus type on family create.
  • Update blank.sql with alembic version 0032 schema
  • Fix configure pyright & pyenv script
  • Use new function scoped db fixture that runs the db migrations ⚠️ - this is 3x slower than before :(

Co-authored-by: @diversemix

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch marked this pull request as ready for review March 26, 2024 15:36
@katybaulch katybaulch requested a review from a team as a code owner March 26, 2024 15:36
@katybaulch katybaulch self-requested a review March 26, 2024 15:46
@diversemix
Copy link
Contributor Author

All looking good from my side of the 🤺

Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peter raised, so I need to close it off 😆 Lovely work from us both if I do say so 😉

@katybaulch katybaulch merged commit 2f21b4a into main Mar 26, 2024
9 checks passed
@katybaulch katybaulch deleted the PDCT-998/ensure-new-documents-have-relationships-in-old-and-new-schema branch March 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants