Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdct 981/admin api if language idempotent language is removed from document #100

Conversation

katybaulch
Copy link
Contributor

Description

When updating a document, the user language was being correctly passed to the API - but if the language was idempotent the API was setting the user language as None in the database.

This PR fixes that bug 🐛

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Have updated update document tests to make sure we are only testing one thing edge case test, as the edge case was not being tested as we were always changing all of the fields in each test. I think we need to review the slug tests however, as I'm not confident that they're working as expected anymore (ticket for doing).

Reviewer Checklist

  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from a team as a code owner March 18, 2024 16:52
Copy link

linear bot commented Mar 18, 2024

Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great nice tests too!

@katybaulch katybaulch merged commit f5d9b31 into main Mar 19, 2024
9 checks passed
@katybaulch katybaulch deleted the PDCT-981/admin-api-if-language-idempotent-language-is-removed-from-document branch March 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants