-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pdct 1368 add the ability to read in all relevant data files #4
Feature/pdct 1368 add the ability to read in all relevant data files #4
Conversation
- add entry point for commands - remove test commands
- this displays the list of available commands and sets it as the default target for the make file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start - think some of the things we've got as click commands can probably just be straightforward functions though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Some of the docstrings are missing param and return descriptions, and I think it would be best to rename the files in your test_fixtures
directory to be more meaningful. Shout if you need a hand or want to walk through it together :)
…nt-data-files' of https://github.com/climatepolicyradar/gcf-data-mapper into feature/pdct-1368-add-the-ability-to-read-in-all-relevant-data-files
- rename test fixtures - update parametrize function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress - have added some comments for review
improve robustness, and refactor code where appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one!!! let's get this in 😁
What's changed?
Adds a function that reads json and csv files passed to the cli (these are very basic and just simply reads these files)
Adds in relevant tests
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x