Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pdct 1368 add the ability to read in all relevant data files #4

Conversation

odrakes-cpr
Copy link
Contributor

@odrakes-cpr odrakes-cpr commented Aug 27, 2024

What's changed?

Adds a function that reads json and csv files passed to the cli (these are very basic and just simply reads these files)
Adds in relevant tests

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Osneil Drakes added 4 commits August 27, 2024 14:24
- add entry point for commands
- remove test commands
- this displays the list of available commands and sets it as the
  default target for the make file
Copy link

linear bot commented Aug 27, 2024

@odrakes-cpr odrakes-cpr requested a review from katybaulch August 27, 2024 15:07
gcf_data_mapper/cli.py Outdated Show resolved Hide resolved
gcf_data_mapper/cli.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start - think some of the things we've got as click commands can probably just be straightforward functions though :)

gcf_data_mapper/cli.py Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@odrakes-cpr odrakes-cpr requested a review from a team as a code owner August 27, 2024 17:02
@odrakes-cpr odrakes-cpr requested a review from katybaulch August 27, 2024 17:03
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some of the docstrings are missing param and return descriptions, and I think it would be best to rename the files in your test_fixtures directory to be more meaningful. Shout if you need a hand or want to walk through it together :)

gcf_data_mapper/read.py Outdated Show resolved Hide resolved
@odrakes-cpr odrakes-cpr requested a review from katybaulch August 28, 2024 13:43
Copy link
Collaborator

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress - have added some comments for review

gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
tests/unit_tests/test_read_data.py Outdated Show resolved Hide resolved
tests/unit_tests/test_read_data.py Outdated Show resolved Hide resolved
tests/unit_tests/test_read_data.py Outdated Show resolved Hide resolved
tests/unit_tests/test_fixtures/test_climate_data.csv Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
gcf_data_mapper/read.py Outdated Show resolved Hide resolved
Osneil Drakes added 2 commits August 29, 2024 10:54
improve robustness, and refactor code where appropriate
Copy link
Collaborator

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!!! let's get this in 😁

@odrakes-cpr odrakes-cpr merged commit a486468 into main Aug 29, 2024
2 checks passed
@odrakes-cpr odrakes-cpr deleted the feature/pdct-1368-add-the-ability-to-read-in-all-relevant-data-files branch August 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants