This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Adding exception to the method. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2023 15:06
PDCT-471 Bug - Fix parser output method that returns bad text
Currently the method on the ParserOutput object vertically flip text blocks is swallowing errors and returning text blocks that haven't actually been flipped. We want to log these out and stop the processing of that document as the bad text blocks will still exist in the text block array. In terms of the indexer code that uses the method, we can continue on documents that have not failed. |
THOR300
commented
Oct 5, 2023
joel-wright
approved these changes
Oct 5, 2023
added 3 commits
October 5, 2023 15:21
THOR300
deleted the
feature/pdct-471-bug-fix-parser-output-method-that-returns-bad-text
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Vertically Flip Coords
Raise exception for failing to flip coords vertically.
This exception is then defined in the data access library and can be caught by the indexer.
We can then continue to index documents that pass this function and review the logs for documents that need fixing.