Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

add version number in pyproject.toml #43

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Conversation

kdutia
Copy link
Member

@kdutia kdutia commented Sep 26, 2023

atm it's hard to see what version of the DAL you have installed as the version number in pyproject.toml is fixed to 0.1.0

pip show cpr_data_access
> Name: cpr-data-access
> Version: 0.1.0
> Summary: 
> Home-page: 
> Author: CPR Tech
> Author-email: tech@climatepolicyradar.org
> License: 
> Location: /Users/kalyan/Library/Caches/pypoetry/virtualenvs/metrics-_FT51am--py3.9/lib/python3.9/site-packages
> Requires: aws-error-utils, boto3, datasets, pandas, pydantic, tqdm
> Required-by: metrics

this PR pre-emptively fixes that for the next version change

@kdutia kdutia requested a review from THOR300 September 26, 2023 14:31
Copy link
Contributor

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a preemptive version manually before merge and tag doesn't feel like the best flow.

I haven't looked thoroughly but I'm wondering if there's a GitHub action for bumping pyproject.toml version.

I.e. on release trigger a workflow that creates a pr with the updated version in the poetry files!

@kdutia kdutia requested a review from THOR300 October 2, 2023 21:13
@kdutia
Copy link
Member Author

kdutia commented Oct 2, 2023

@THOR300 I couldn't find a github action that bumps pyproject version and haven't got time to look into creating one.

I've added a quick 'does main have a greater version than the last release' check to this PR instead which solves the issue i'm interested in (ensuring local machines contain sensible version numbers) – I suggest if you're interested in auto version bump on release we could ticket that up separately?

Copy link
Contributor

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as we aren't going to implement a different solution any time soon this is a good simple solution to the problem.

@kdutia kdutia merged commit 56217c3 into main Oct 3, 2023
4 checks passed
@kdutia kdutia deleted the fix/pyproject-toml-version-number branch October 3, 2023 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants