-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a preemptive version manually before merge and tag doesn't feel like the best flow.
I haven't looked thoroughly but I'm wondering if there's a GitHub action for bumping pyproject.toml version.
I.e. on release trigger a workflow that creates a pr with the updated version in the poetry files!
…m/climatepolicyradar/data-access into fix/pyproject-toml-version-number
@THOR300 I couldn't find a github action that bumps pyproject version and haven't got time to look into creating one. I've added a quick 'does main have a greater version than the last release' check to this PR instead which solves the issue i'm interested in (ensuring local machines contain sensible version numbers) – I suggest if you're interested in auto version bump on release we could ticket that up separately? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as we aren't going to implement a different solution any time soon this is a good simple solution to the problem.
atm it's hard to see what version of the DAL you have installed as the version number in pyproject.toml is fixed to
0.1.0
this PR pre-emptively fixes that for the next version change