Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland related modifications #5

Open
wants to merge 2 commits into
base: im-support
Choose a base branch
from

Conversation

xfangfang
Copy link

The content of this PR has only been tested under textInputV3, as my understanding of Wayland is limited, so it may contain issues.

1. Improves

The current Wayland implementation defaults to automatically enabling the input method when the application starts, leading to:

Therefore, I directly removed the keyboard activation functions of textInputV1Enter and textInputV3Enter, and at the same time, simply implemented the IME status-related functions, allowing users to enable or disable the keyboard through glfwSetInputMode.

2. Fix for endless preedit cursor update

While implementing the above, I found that textInputV3Done is called repeatedly after the application starts.

After reading the documentation:

  • When the client receives a done event with a serial different
  • than the number of past commit requests, it must proceed with
  • evaluating and applying the changes as normal, except it should
  • not change the current state of the zwp_text_input_v3 object.

I made a simple adjustment, calling zwp_text_input_v3_set_cursor_rectangle / zwp_text_input_v1_set_cursor_rectangle only when the coordinates change. As I tested with an on-screen keyboard, I am not sure if it will affect the other input method, but it did indeed stop the loop of textInputV3Done being called repeatedly.

@ashie
Copy link
Member

ashie commented Sep 18, 2024

While implementing the above, I found that textInputV3Done is called repeatedly after the application starts.

After reading the documentation:

  • When the client receives a done event with a serial different
  • than the number of past commit requests, it must proceed with
  • evaluating and applying the changes as normal, except it should
  • not change the current state of the zwp_text_input_v3 object.

ref: https://wayland.app/protocols/text-input-unstable-v3#zwp_text_input_v3:event:done

@ashie
Copy link
Member

ashie commented Sep 18, 2024

Thanks for your feedback!

  1. Fix for endless preedit cursor update

The fix for this issue looks good.

  1. Improves

I have some concerns on this fix.
It seems that it introduces different UX with other platform especially Windows.
(We consider that the Windows backend is the reference implementation of multi-platform IM feature.)
In this context, IM can be always enabled or disabled by one of these elements:

  • Short keys
  • Panel UI provided by IM frame work
  • Application

and the status should be synchronized no matter what element you use.
But this fix doesn't seem synchronized, and only the application can enable IM at start up.

@xfangfang
Copy link
Author

It seems that it introduces different UX with other platform especially Windows.

This is indeed a problem. I have only tested the touchscreen experience in the Wayland desktop environment (SteamDeck) of KDE, and have not found a way to manually turn off the on-screen keyboard. I have also not tested the support for other input methods.

I may install Wayland on my new computer for more detailed testing in about a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants