Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove motion require #251

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

markrickert
Copy link
Contributor

This PR completely removes motion-require. It's no longer needed for the newest versions of RubyMotion.

I don't expect this to get merged because this repo is a total 👻 town, but I figured I'd send the PR anyways so anyone having the same issues I was when trying to update an app that was a few years old.

If you're having problems with this library while updating your app, use this in your gemfile:

gem 'formotion', github: 'markrickert/formotion', branch: 'remove-motion-require'

...unless this gets merged and a new version is released 😉

Fixes #250

@smtm
Copy link
Contributor

smtm commented Oct 31, 2018

Thanx Mark, this branch is a lifesaver. I used this branch to build a latest version of the gem locally and reactivate my app. I battled with startup of the rake task.

This Message appeared at app start time. I tore out my hair for hours and went down the rabbit hole of hunting "Possible cyclical dependency between", "class hierarchy. Consider revision if runtime exceptions occur around undefined symbols."...

*** Terminating app due to uncaught exception 'NameError', reason: 
../gems/formotion-1.8/lib/formotion/controller/formab: uninitialized constant Formotion::FormController (NameError)

@markrickert
Copy link
Contributor Author

@smtm Thanks for reporting back that this helped you! Sometimes putting things out there like this never get a response so I'm glad it was useful to someone other than me!

@cmckni3
Copy link

cmckni3 commented Sep 14, 2019

This helped me as well update from RubyMotion 4.16 and formotion 1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclical dependencies and motion_require
3 participants