Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changes suggested by Mauricio. #202

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Implement changes suggested by Mauricio. #202

merged 2 commits into from
Aug 13, 2019

Conversation

ketch
Copy link
Member

@ketch ketch commented Jul 17, 2019

See #200.

@rjleveque
Copy link
Member

I think in Approximate_solvers we need to replace \wave with {\matcal W} and \apdq with {\cal A}^+ since the macros aren't found (are they supposed to be)? Elsewhere these are written out explicitly.

I don't know what's going on with travis, but the tests seem to pass.

@ketch
Copy link
Member Author

ketch commented Jul 31, 2019

I think in Approximate_solvers we need to replace \wave with {\matcal W} and \apdq with {\cal A}^+ since the macros aren't found (are they supposed to be)? Elsewhere these are written out explicitly.

I made this work earlier with a plugin, but it's not worth it at this point. So I made these changes, except I used \cal because \mathcal didn't work.

@rjleveque
Copy link
Member

Grepping mathcal it seems to be used in other notebooks such as Shallow_water_approximate and seems to work fine. (But note I misspelled it in my comment above, so if you copied and pasted, matcal wouldn't work.)

But the resulting rendered version seems to be the same with either one, so I don't think it matters.

@ketch
Copy link
Member Author

ketch commented Aug 13, 2019

if you copied and pasted

LOL, yes, I did exactly that. Must not have been thinking too clearly at the time...

@ketch ketch merged commit 1d10804 into master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants