-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
704 add instructor approved i note to playlist screen for each video #829
base: staging
Are you sure you want to change the base?
704 add instructor approved i note to playlist screen for each video #829
Conversation
In the first screenshot of the playlist media cards there's insufficient contrast for the buttons ; The new I-Note button text is too dark i.e. brightness is too close to the black background to be legible. |
Green hover. Unfortunately this does not meet accessibility requirements: Contrast must always be sufficient. Also not everyone uses a mouse (e.g. instead uses tab to move focus) - so hover wouldnt work for that use case. |
I'm using the same teal green color that is being used currently when hovering over a video: I can make it this lighter green maybe: Thanks for pointing out the tab issue I'll try to add something to incorporate that. I also want to add that I-note button is now white when not being hovered over / focused on, so the contrast there is sufficient right? |
White when not hover; yes - that will be great. |
Fixes #704
Adds I-note button to each video in the watch playlist menu, which links to i-notes created for this video.
First video's i-note button links here:
I was having trouble adjusting the styling to something nicer, so if anyone wants to change things that would be great.