docs: clarify account usage, and document global case #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportNote Coverage data for the default branch was not found. The coverage rate is None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
BzSpi
approved these changes
Oct 10, 2023
mloskot
reviewed
Oct 10, 2023
Comment on lines
+487
to
+490
| - `account`: an account alias which may refer to provider accounts or subscriptions, e.g. `project-a-prod`, `customer-b-dev`. | ||
| - `environment`: `production`, `preproduction`, `dev`, etc. With `global` as a special case eliminating the `region` part. | ||
| - `region`: `eu-west-1`, `westeurope`, etc. | ||
| - `stack`: defaults to `default`. `web`, `admin`, `tools`, etc. |
There was a problem hiding this comment.
This from #246 (comment)
does not contain
/or_characters.
actually is an undocumented requirement.
Being ANAL here: it is left to be deduced by a reader from the ${account}_${environment}_${region}_${stack}.yml and the fact that if _-s are used as separators, then likely those can't be used in names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #246