Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] fix: trigger playback ready event when rendered #75

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP] fix: trigger playback ready event when rendered #75

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad3c140
fix: trigger playback ready event when rendered
kslimani Jan 29, 2020
a162613
fix: store user interaction before setup Shaka instance
kslimani Jan 29, 2020
2296dd1
fix: avoid uncaugth error when manifest not available
kslimani Jan 30, 2020
2393e2a
chore: use latest level selector plugin in dev. index page
kslimani Jan 30, 2020
8244eeb
docs(readme): update jsDelivr script urls
kslimani Jan 30, 2020
a4535ae
feat: add level property in PLAYBACK_LEVELS_AVAILABLE event object
kslimani Jan 31, 2020
74c8a62
fix: handle tracks with multiple languages
kslimani Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/clappr-dash-shaka-playback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,18 @@ class DashShakaPlayback extends HTML5Video {
}

getCurrentTime() {
return this.shakaPlayerInstance.getMediaElement().currentTime - this.seekRange.start
return this.shakaPlayerInstance
? this.shakaPlayerInstance.getMediaElement().currentTime - this.seekRange.start
: 0
}

get _startTime() {
return this.seekRange.start
}

get presentationTimeline() {
if (!this.shakaPlayerInstance) return

return this.shakaPlayerInstance.getManifest().presentationTimeline
}

Expand All @@ -99,7 +103,11 @@ class DashShakaPlayback extends HTML5Video {
}

getProgramDateTime() {
return new Date((this.presentationTimeline.getPresentationStartTime() + this.seekRange.start) * 1000)
let presentationStartTime = this.presentationTimeline
? this.presentationTimeline.getPresentationStartTime()
kslimani marked this conversation as resolved.
Show resolved Hide resolved
: null

return new Date((presentationStartTime + this.seekRange.start) * 1000)
}

_updateDvr(status) {
Expand Down Expand Up @@ -127,7 +135,10 @@ class DashShakaPlayback extends HTML5Video {

play () {
if (!this._player) {
this._setup()
// User interaction is lost when Shaka instance load() fetch the manifest
// Calling consent() before setup Shaka instance fix this issue (Safari browser on macOS)
this.consent()
process.nextTick(() => this._setup())
}

if (!this.isReady) {
Expand Down Expand Up @@ -155,15 +166,13 @@ class DashShakaPlayback extends HTML5Video {
// skipping HTML5Video `_setupSrc` (on tag video)
_setupSrc () {}

// skipping ready event on video tag in favor of ready on shaka
_ready () {
// override with no-op
this.trigger(Events.PLAYBACK_READY, this.name)
}

_onShakaReady() {
this._isShakaReadyState = true
this.trigger(DashShakaPlayback.Events.SHAKA_READY)
this.trigger(Events.PLAYBACK_READY, this.name)
}

get isReady () {
Expand Down