Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: separated module readme example #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Raduc4
Copy link

@Raduc4 Raduc4 commented Nov 16, 2022

Hi, I have tried to extract the sentiment analyzer into a separate function but the example from the docs didn't work, I have figured out how to deal with it and wanted to contribute to this project, maybe someone will encounter the same problem in the future.

@marimeireles
Copy link
Collaborator

Hey @Raduc4 glad you want to contribute this back!
I understand what you mean but I don't think it's clear enough on the README, could you add some extra strings explaining why someone would want to use your code?
Also, please make sure that your code is a minimal reproducible example, as in, the most generic possible and not your specific use case.
Once these changes are addressed I'm happy to merge it!
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants