WIP: Unify DOS and SDL music player #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the DOS version has nicer integration with the editor, we'll base it off the DOS PC speaker interface: - sound(f); delay(d); -> audio_square(f, d); - nosound(f); delay(d); -> audio_silence(f, d);
Rather than allocating and reallocating a monster buffer of the entire audio stream, generate it on demand from a smaller buffer of notes. This still needs: - callback emits an event to tell the player it needs more notes - wait until buffer is drained before closing audio It would also be nice to make a less harsh waveform. It should be relatively simple to add polybleps on the samples surrounding the transition.
- Fix rendering rests (wasn't writing silence to buffer) - Request more notes when buffer running low - Drain the buffer before closing the device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DOS-like sound functions to the display interface so that both DOS and SDL can use the same music player in the text editor.
This finally lets SDL follow along with the playing music like DOS does.