Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return hll_empty for no input rows in hll_add_agg #155

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beyzaaydogan
Copy link

When I debugged Issue #129, I observed that the state transition function, hll_add_trans, was not being called at all. This was because the values used in the filter did not satisfy the condition. However, I noticed that the final function, hll_pack, was called with a null input. In this case, I made development so that if hll_pack is called with a null input, it will return hll_empty.

hll_pack is the final function for hll_union_agg as well. With my fix, if hll_pack is called with a null parameter while using hll_union_agg, it returns hll_empty. This is causing the failure of this test:

SELECT hll_union_agg(v1) FROM test_wdflbzfx WHERE recno > 100;

Moreover, when hll_add_agg is directly called with null parameters, it also returns hll_empty, as mentioned in Issue #2. However, hll_union_agg returns null in such a case. Shouldn't hll_union_agg also return hll_empty when called with null parameters? What are your thoughts on this matter?

hll_add_agg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant