Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document N_0x45f35c0edc33b03b #909

Closed
wants to merge 5 commits into from
Closed

Document N_0x45f35c0edc33b03b #909

wants to merge 5 commits into from

Conversation

freedy69
Copy link
Contributor

Added this native's purpose and an example on how to use it

@freedy69
Document N_0x45f35c0edc33b03b
9a371b6 
Added this native's purpose and an example on how to use it
@freedy69
Document parameters
3d9019b
Z3rio
Z3rio suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@Z3rio Z3rio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great PR, just a bit of final touches, capitalization, etc
Feel free to look through my suggestions and see if you think any of them would improve the PR

NETWORK/NetworkAddMapObjectToSynchronisedScene.md Outdated Show resolved Hide resolved
NETWORK/NetworkAddMapObjectToSynchronisedScene.md Outdated Show resolved Hide resolved
NETWORK/NetworkAddMapObjectToSynchronisedScene.md Outdated Show resolved Hide resolved
NETWORK/NetworkAddMapObjectToSynchronisedScene.md Outdated Show resolved Hide resolved
NETWORK/NetworkAddMapObjectToSynchronisedScene.md Outdated Show resolved Hide resolved
@freedy69
Update params and spelling
aed2b4d 
Added changes suggested by Z3rio
@freedy69
Copy link
Contributor Author

Overall great PR, just a bit of final touches, capitalization, etc Feel free to look through my suggestions and see if you think any of them would improve the PR

Thank you, fixed it

@4mmonium 4mmonium added the changes types This pull request changes types, possibly breaking ABI compat. Needs checking. label Nov 15, 2023
@freedy69 freedy69 closed this by deleting the head repository Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4mmonium 4mmonium 4mmonium left review comments

@Z3rio Z3rio Z3rio requested changes

Assignees
No one assigned
Labels
changes types This pull request changes types, possibly breaking ABI compat. Needs checking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freedy69 @4mmonium @Z3rio