Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the format of the version tracking file #379

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Change the format of the version tracking file #379

wants to merge 1 commit into from

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Oct 10, 2024 •
edited
Loading

🗣 Description

This pull request removes the Python trappings from the version tracking file (src/version.txt). The version tracking file is changed to be a flat text file storing the version.

💭 Motivation and context

When writing #377 I found myself questioning why the version was stored as it currently is and decided it should be changed.

🧪 Testing

Automated tests pass. I confirmed that the bump_version.sh script worked as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 10, 2024
@mcdonnnj mcdonnnj self-assigned this Oct 10, 2024
@mcdonnnj
Change the format of the version tracking file
13c5ef6 
There is no reason to have any information but the version in the
version tracking file for Packer template projects. The current format
is simply an artifact of mirroring things over from the
cisagov/skeleton-python-library project.
@mcdonnnj mcdonnnj force-pushed the improvement/change_version_file_format branch from cf59ea7 to 13c5ef6 Compare October 10, 2024 20:55
dav3r
dav3r approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
breaking change This issue or pull request involves changes to existing functionality hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r