Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ao vpn ports #76

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add ao vpn ports #76

merged 2 commits into from
Oct 30, 2024

Conversation

patrick-fox-cisa
Copy link
Contributor

@patrick-fox-cisa patrick-fox-cisa commented Oct 30, 2024 •
edited by dav3r
Loading

🗣 Description

This PR makes 100 additional TCP and 100 additional UDP ports available for use by the AO team.

💭 Motivation and context

The current number of ports is no longer enough to meet the needs of the AO team.

🧪 Testing

  • Applied this change in Staging
  • @patrick-fox-cisa verified that the ports are accessible in Staging as expected

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Apply this change in Production

@patrick-fox-cisa
Add ao vpn ports
1dd3a7e 
Ops need more ports
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 30, 2024
@dav3r dav3r self-assigned this Oct 30, 2024
dav3r
dav3r reviewed Oct 30, 2024
View reviewed changes
locals.tf Show resolved Hide resolved
@dav3r
Copy link
Member

dav3r commented Oct 30, 2024

@patrick-fox-cisa I applied this change in Staging. Please verify that it works as expected.

@patrick-fox-cisa
Copy link
Contributor Author

Tested and working as expected, including the old ports.

dav3r
dav3r approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @patrick-fox-cisa!

@dav3r dav3r merged commit c3ad7d7 into cisagov:develop Oct 30, 2024
2 checks passed
@dav3r
Copy link
Member

dav3r commented Oct 30, 2024

@patrick-fox-cisa - I just applied this change in Production as well.

@dav3r dav3r added the hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@dav3r dav3r

Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-fox-cisa @dav3r @jsf9k